On Wed, 15 May 2013, Phil Dibowitz wrote: >> Phil, did you have any more comments on the Windows build fix patch (v3)? >> If not, it could probably be merged? > > Few questions/comments > > 1. You add a bunch of project files, as opposed to updating them... why?
Well, the existing ones are in an old format used by older versions of Visual C++. I thought about trying to manually edit them by hand, but I wouldn't have any way of testing them. > 2. You dropped support for a bunch of build environments which is fine, but > a. we should remove the related project files > b. we should not list "one of the following" in the readme if there's only > one option :) Yeah, we can do that. That was part of the earlier discussion that I had (with myself apparently. :)) > 3. Why the extra abstraction in HID_WriteReport in winhid.cpp? That was the stack corruption fix that I referred to in the commit message. Basically, on Windows, we have to add an extra byte at the beginning of each packet. Since the buffer being supplied HID_WriteReport does not account for this, we have to allocate our own (larger) buffer in order to have space for this extra byte. ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
