On Mon, 30 Sep 2013, Phil Dibowitz wrote: > A few minor comments below. Also, have you tried a zwave remote in Windows? > What happens with all the dhcp stuff? My understanding is windows usblan > driver handles that inherently?
I haven't tried a usbnet remote in Windows as I don't really have access to one. I believe Concordance should work as long as the Logitech software has already been installed (and thus the Logitech USBNET driver and DHCP server are in place...at least I think these were installed by the Logitech software and not part of Windows itself). Otherwise, the user would have to somehow get a USBNET driver and a DHCP server. > Also, it feels like now that this is built with configure/make/make install, > that we can now have INSTALL.windows but split among the projects the way we > do for linux and mac. Okay, I'll take care of that in v2. > On 09/30/2013 08:15 PM, Scott Talbert wrote: >> // Make the socket non-blocking so it doesn't hang on systems that >> // don't have a usbnet remote. >> - int flags = 0; >> fd_set wset; >> FD_ZERO(&wset); >> FD_SET(sock, &wset); >> @@ -110,6 +109,7 @@ int FindUsbLanRemote(void) >> return LC_ERROR_OS_NET; >> } >> #else >> + int flags = 0; > > The #if attached to this #else is a 'WIN32' instead of a '_WIN32' > > Also, CPP shouldn't be indented... while you're there, can you fix that? Okay, fixed both issues in v2. >> -//User-Agent: HarmonyBrowser/7.7.0 (Build 0; UpdatedFrom 7.3.0.15; Skin >> logitech; Windows Vista 6.1; x86; en; rv: 1.8.0.2) Gecko/20060125\r\n\ >> - > > I get a feeling we'll need to start using this soon... it might be nice to > leave there in a comment. Okay, I'll put it back. GCC was complaining about it being a multi-line comment, but we can just ignore that for now. ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel