On Sat, 15 Feb 2014, Phil Dibowitz wrote: >>>> This fixes building on OSX as well as config-updates for 89x on OSX. >>> >>> Scott, >>> >>> Does this seem reasonable to you? Even though some things still don't work >>> on >>> OSX, this fixes a TON of them. The only potentially scary part here is the >>> removal of the hid_exit() call... >> >> Does what seem reasonable? Did you intend to send another version of the >> patch? :-) Because the one you sent back in Dec didn't have hid_exit >> removed. > > Oh, sorry, I thought the last one I sent was the most recent... but here.
Yeah, I guess it seems OK. The things that are timing related are kind of worrisome, but not sure what to do about them. Have you tested without hid_exit() on Linux? On Windows, it doesn't look hid_exit() actually does anything. On Linux, it calls libusb_exit() - I'm not sure what the consequences of not calling that would be. We probably ought to be calling hid_exit() when concordance exits, though. Which probably would mean adding a function to libconcord so that concordance can call it when it is about to exit. ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
