On 03/17/2014 09:13 PM, Phil Dibowitz wrote: > On 03/17/2014 04:17 PM, Scott Talbert wrote: >> On Mon, 17 Mar 2014, Phil Dibowitz wrote: >> >>>> I actually meant the part where you (I think you) had checked for an >>>> INFORMATION tag to "sanity check" - and now I fall through that if we don't >>>> find that tag... because otherwise we never recognize our own FW dump >>>> files. >>>> >>>> Alternatively, I could modify our FW dump code to add INFORMATION tags >>>> around >>>> the file... >>> >>> BTW, here's a version that updates the py bindings too. >> >> Actually, I don't recall ever messing with that particular part of the >> code. I think I would lean towards adding the INFORMATION tags around the >> file. It seems like that would be more consistent with what we do for >> config dumps - it looks like we wrap that with some tags. > > Yeah - my only concern is it means we're incompatible with dumps made by > previous versions, and that sucks. :(
I'm splitting these patches up, and my operationfile one does both - makes new files better, but supports old files. I went ahead and committed just the comments to GetTag() The other two I'll send shortly. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
