I just checked out a fresh copy from git, applied the patch, and it
compiled fine. So, it looks like your source tree might have gotten out
of whack somehow. I'd suggest just checking out a fresh copy?
Scott
On Tue, 1 Apr 2014, Cédric de Launois wrote:
Hi Scott,
I get compile errors after applying your patch :
gcc -DHAVE_CONFIG_H -I. -Wall -ansi -pedantic-errors -g -O2 -MT
concordance-concordance.o -MD -MP -MF .deps/concordance-concordance.Tpo -c
-o concordance-concordance.o `test -f 'concordance.c' || echo
'./'`concordance.c
concordance.c: In function ‘print_version_info’:
concordance.c:903:9: warning: implicit declaration of function
‘mh_get_serial’ [-Wimplicit-function-declaration]
concordance.c:903:9: error: passing argument 1 of ‘strlen’ makes pointer
from integer without a cast
/usr/include/string.h:399:15: note: expected ‘const char *’ but argument is
of type ‘int’
concordance.c:904:13: warning: format ‘%s’ expects argument of type ‘char
*’, but argument 2 has type ‘int’ [-Wformat]
The code I'm compiling is the master branch with you patch v11 applied .
Cedric
2014-04-01 5:55 GMT+02:00 Scott Talbert <s...@techie.net>:
Hi Cedric,
Some other news - I think I finally reverse engineered the
format that the Touch uses for setting the time. I've got a new
patch for concordance (attached) that hopefully implements the
time setting properly. If you can also test this when you get a
chance, that would be much appreciated. Basically, run it and
see if it reports any errors and also check to see whether the
date and time is properly set on your remote after running it.
To test it (much easier than doing a sync!) you can just run:
"concordance -K".
Note: I rebased the patch on git master (with Phil's latest
commits), so you will probably have to roll back the old patch,
do a git pull, and then apply this new patch.
Once we confirm the time setting works, I can add it to the
config sync process, but I don't want to change that while we
are still testing the basic sync stuff. :)
Thanks,
Scott
On Mon, 31 Mar 2014, Cédric de Launois wrote:
Great. I'll take a look.
Regarding the complete sync failure last time, I
agree it is certainly not
related to your latest changes. It may be related to
the firmware upgrade
that logitech forced during the last config sync.
Hope my remote won't crash
every next failed sync ;-)
Thx again,
Cedric
2014-03-31 2:39 GMT+02:00 Scott Talbert
<talb...@techie.net>:
OK, so the problem wasn't with the locale per
se, but with
positive UTC offsets. Once I set my clock to
UTC+1, I was able
to see the problem. I've pushed a fix for
this. Please try
again at your convenience. Hopefully this
might work. :-) But
if it still fails, could you please do a
Wireshark capture of
both the failed mhgui and successful Logitech
sync.
Thanks
Scott
On Sun, 30 Mar 2014, Scott Talbert wrote:
Actually, after remembering what problem
I was
looking at last time (problems with
dates), I looked
and sure enough, those dates appear to
still be
problematic. The weird thing is, the
date handling
seems to work fine on my machine. I'll
have to try
it on Ubuntu to see if I can reproduce
the problem
there, or maybe with your locale.
So, no need for a new capture just yet.
:)
Scott
On Sun, 30 Mar 2014, Scott Talbert
wrote:
Hi Cedric,
Sorry about that, but I'm not sure
why
this time it would have broken the
remote any worse than before. :-)
There weren't any changes in the
code
that interact with the remote,
just
logging changes.
Anyway, unfortunately, I was not
able to
tell anything from the logs -
there were
differences but it wasn't possible
to
sort out the differences that were
due
to MHGUI vs differences in the
configuration.
Can you try again? Unfortunately
at
this point, I really need to see
mhgui
and Logitech attempting to do the
exact
same operation. Also, please do a
Wireshark capture of both USB
interactions.
Thanks,
Scott
On Fri, 28 Mar 2014, Cédric de
Launois
wrote:
Ouch, this time the failure
of mhgui completely broke
the remote. I had to
perform a hardware reset
because logitech was no
longer able to sync it.
I forgot all the changes I
made, so it may appear that
the config sync by
logitech is somewhat
different from the sync I
made with mhgui.
It is difficult to perform
the exact same sync if the
remote is crashing
with mhgui...
Hope this trace will help
anyway.
Cedric
---------------------------------------------------------------------------
---
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
------------------------------------------------------------------------------
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
