Axel Beckert <[EMAIL PROTECTED]> writes: > Hi, > On Tue, Jun 10, 2008 at 07:18:10PM -0400, Jeremy Maitin-Shepard wrote: >> Thanks for creating a Debian package for Conkeror. Hopefully it will >> help increase the Conkeror userbase. After looking over the package, I >> have just a few comments: >> >> 1. The conkeror.xulapp file should not be included, as it is used only >> for a particular method of installing Conkeror, and is not needed >> after that.
> Already noticed that. This, and some more things of that kind, are > already fixed in my packaging repository[1] and will be fixed with the > next release of the package. > [1] http://noone.org/hg/conkeror/debian -- I currently use Mercurial > (hg), but will probably switch to git which can make things > easier because conkeror itself uses git. It might be slightly easier if you used included the conkeror repository in your packaging repository via git submodules, or alternatively used the subtree merge strategy. As far as I understand (I've never used them myself), submodules should do exactly what you need, but their use is somewhat complicated. >> 2. The -help command-line option is actually handled by xulrunner >> itself, and merely displays the canned xulrunner usage >> information. > Seems so, yes. >> The -width and -height options advertised are not actually >> functional, > Noticed that, too. It's a known bug in Mozilla since 2000. :-( >> so they should be removed from the man page. > I will include hints in the --help output as well as the man page > pointing to the bug reports I posted already to the list. The only bug, though, is that the options are listed in the --help output. There isn't anything in Mozilla that could be fixed to support those options --- Conkeror itself would need to handle them and do something with them. One other suggestion I have is that you include somewhere in the package the commit name (hash) of the version of Conkeror that is incorporated, so that in the case of bug reports it is easier to know exactly what version the user has. Possibly a place to include it would be application.ini, setting BuildID to the actual commit name instead of the string "git". (This is done automatically by the build.sh script in preparing the xulapp file, but your Debian package doesn't make use of the xulapp files.) -- Jeremy Maitin-Shepard _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
