On Tue, Nov 17, 2009 at 10:14:23PM +1030, David Kettler wrote: > The composable browser object introduced in b1c194a > (browser-object-text: new composable browser object, bound to T, > 2009-11-16) failed when no explicit browser object was given. For > example the keys "T c" resulted in an error. > > Determining the default browser object is now performed when the > object is read, which allows composition with the default, so that > those keys now work. > --- > > Moving the default handling from call_interactively (as is done here) > is the most straightforward fix, but perhaps doesn't respect the > abstraction boundaries. > > The existing default handling was a little obscure; I think the order > in which to choose a default goes: > > - I.binding_browser_object; > - I.command.browser_object, only if it's a literal, not a class > - I.buffer.default_browser_object_classes > - I.command.browser_object > > The text of this patch depends on [[PATCH] Give a useful error message > when no browser object type is specified], but could easily be made > independent.
I was thinking along the same lines, but I'm going to take some time to think this through. -- John Foerch _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
