Hi Fred,
On Tue, Oct 26, 2010 at 09:56:27PM -0400, Fred Concklin wrote:
> Got following error upon launch:
>
> Error: Module not found
> file:///usr/share/conkeror/components/application.js:204
> Error("Module not found")@:0
>
> ("page-modes/stackoverflow.js","stackoverflow")@file:///usr/share/conkeror/components/application.js:204
>
> ("page-modes/stackoverflow.js")@file:///usr/share/conkeror/components/application.js:278
> handle_command_line([object
> XPCWrappedNative_NoHelper])@chrome://conkeror/content/command-line.js:174
> ([object
> XPCWrappedNative_NoHelper])@file:///usr/share/conkeror/components/command-line.js:23
> Console error: [JavaScript Error: "default_global_keymap is not defined"
> {file: "chrome://conkeror/content/buffer.js" line: 57}]
> Category: chrome javascript
> Console error: [JavaScript Error: "default_global_keymap is not
> defined" {file: "chrome://conkeror/content/buffer.js" line: 57}]
> Category: XPConnect JavaScript
>
> Two patches attached. Was unable to run conkeror without them from most
> recent pull (f044e932b002ec834725b58404ef7ba36bc8c613) on:
Hmmm, so you build your conkeror .deb package yourself from the latest
HEAD which is from yesterday. So this should be reproducible with the
latest conkeror nightly build.
But running today's nightly build on Debian Unstable with
xulrunner-1.9.1 just gives a warning about an undeclared variable in
xulrunner's extension manager.
> diff --git a/defaults/preferences/default-modules.js
> b/defaults/preferences/default-modules.js
> index 01e4f3b..5205b4b 100644
> --- a/defaults/preferences/default-modules.js
> +++ b/defaults/preferences/default-modules.js
> @@ -42,14 +42,24 @@ pref("conkeror.load.mode-line", 1);
> pref("conkeror.load.daemon", 1);
>
> pref("conkeror.load.favicon", 1); // Enhances tab-bar mode
> +pref("conkeror.load.tab-bar", 0);
> +
> +// Extension support modules
> +// These modules will automatically skip loading if the associated extension
> is not enabled.
> +pref("conkeror.load.extensions/dom-inspector", 1);
> +pref("conkeror.load.extensions/adblockplus", 1);
> +pref("conkeror.load.extensions/venkman", 1);
> +pref("conkeror.load.extensions/noscript", 1);
Not 100% sure if we really want that. It's an idea which can be
discussed.
But it's surely not needed in relation with the
stackoverflow/stackexchange mode.
> // Page mode modules
> pref("conkeror.load.page-modes/youtube", 1);
> pref("conkeror.load.page-modes/reddit", 1);
> +pref("conkeror.load.page-modes/google-search-results", 0);
> pref("conkeror.load.page-modes/google-calendar", 1);
> pref("conkeror.load.page-modes/google-reader", 1);
> pref("conkeror.load.page-modes/google-video", 1);
> pref("conkeror.load.page-modes/google-maps", 1);
> pref("conkeror.load.page-modes/dailymotion", 1);
> +pref("conkeror.load.page-modes/gmail", 0);
I don't think we should move away from John's defaults here without
John's consent. Surely not needed in relation with the
stackoverflow/stackexchange mode.
> pref("conkeror.load.page-modes/xkcd", 1);
> -pref("conkeror.load.page-modes/stackexchange", 1);
> +pref("conkeror.load.page-modes/stackoverflow", 1);
That's basically a revert of the first hunk of the commit
http://repo.or.cz/w/conkeror.git/commitdiff/16431431657b506c8ba0890f736aa2370fa22788
(which renamed the stackoverflow mode to stackexchange mode). But it
reverts only the first hunk which changes the path to where to look
for the mode.
> diff --git a/modules/external-editor.js b/modules/external-editor.js
> index 9343c8b..0a7832f 100644
> --- a/modules/external-editor.js
> +++ b/modules/external-editor.js
> @@ -5,9 +5,7 @@
> * COPYING file.
> **/
>
> -in_module(null);
> -
> -define_variable("editor_shell_command", getenv("VISUAL") || getenv("EDITOR")
> || "emacs",
> +define_variable("editor_shell_command", "/usr/bin/sensible-editor",
> "Shell command used to invoke an external editor.\n" +
> "This defaults to the value of the EDITOR environment variable. If " +
> "`run_external_editor_function' is non-null, it is used instead to " +
> @@ -80,5 +78,3 @@ function open_with_external_editor (lspec) {
> let [file, temp] = yield download_as_temporary(lspec);
> yield open_file_with_external_editor(file, $line = arguments.$line,
> $temporary = temp);
> }
> -
> -provide("external-editor");
That looks a lot like a git working copy after building a debian
package, but not running "dpkg-buildpackage clean" afterwards.
> diff --git a/modules/stylesheet.js b/modules/stylesheet.js
> index 5a60665..20937a0 100644
> --- a/modules/stylesheet.js
> +++ b/modules/stylesheet.js
> @@ -87,7 +87,7 @@ function make_css_data_uri (rules) {
> if (restrictions)
> rules = "@-moz-document "+restrictions+" {\n"+rules+"\n}";
> if (namespace)
> - rules = "@namespace url("+namespace+");\n"+rules;
> + rules = "@namespace url("+namespace+")\n"+rules;
> return make_uri("data:text/css,"+escape(rules));
> }
>
That's basically a revert of the last commit from yesterday which fixes
a CSS syntax error or so:
http://repo.or.cz/w/conkeror.git/commitdiff/f044e932b002ec834725b58404ef7ba36bc8c613
> From ec7c98a1a6a249a480f9a63898eedae4b808eaa6 Mon Sep 17 00:00:00 2001
> From: Fred Concklin <[email protected]>
> Date: Tue, 26 Oct 2010 21:29:11 -0400
> Subject: [PATCH 2/2] stack overflow default-modules.js changed to stack
> exchange
>
> ---
> defaults/preferences/default-modules.js | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/defaults/preferences/default-modules.js
> b/defaults/preferences/default-modules.js
> index 5205b4b..e8e3bd0 100644
> --- a/defaults/preferences/default-modules.js
> +++ b/defaults/preferences/default-modules.js
> @@ -62,4 +62,4 @@ pref("conkeror.load.page-modes/google-maps", 1);
> pref("conkeror.load.page-modes/dailymotion", 1);
> pref("conkeror.load.page-modes/gmail", 0);
> pref("conkeror.load.page-modes/xkcd", 1);
> -pref("conkeror.load.page-modes/stackoverflow", 1);
> +pref("conkeror.load.page-modes/stackexchange", 1);
And that's reapplying the first hunk of
http://repo.or.cz/w/conkeror.git/commitdiff/16431431657b506c8ba0890f736aa2370fa22788
after you reverted it in the last patch. Sorry, but I don't get the
idea behind that.
I'm sorry, but with the two patches which neutralize themselves,
nothing related to the stackoverflow/stackexchange mode changed and
all other changes were either loading some more modes or reverting a
commit which fixed a CSS syntax error.
If there's not a strange relation that stackoverflow/stackexchange
mode only works with that CSS syntax error mentioned above, I doubt
that those two patches fix the error above.
The first patch however can cause it, due to it reverting the
stackoverflow/stackexchange renaming at one point, but not at all the
other points where it was changed.
Kind regards, Axel
--
/~\ Plain Text Ribbon Campaign | Axel Beckert
\ / Say No to HTML in E-Mail and News | [email protected] (Mail)
X See http://www.asciiribbon.org/ | [email protected] (Mail+Jabber)
/ \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)
_______________________________________________
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror
