> Merged patch with some changes. Thanks.
>> Relatedly, the change to keymap.js suppresses a warning on >> describe-command with modern XULRunner. > > This change is not related, and should be in a separate patch. So it should; I only noticed the problem once I had added the doc changes, but it is independent of those changes. It looks like the bindings that cause the warning (because they have no command member) come from prefix keys in a multiple key binding. > I would have done so, except that it is not specific enough to say > "modern" XULRunner. Of the versions I have available, 1.9.1 does not complain but 9.0, 10.0 and 11.0 do. But I don't know when that warning started to be issued, Debian doesn't offer me other versions to try and I don't think its worth installing older versions to answer this question. Would wording like the following suffice? Suppress a warning in describe-command XULRunner 9.0 (and perhaps earlier) complains when an attempt is made to access an undefined property of an object. Binding objects do not always have a command property so, check that it is defined before accessing it. Regards, David _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
