[ 
https://issues.apache.org/jira/browse/CONNECTORS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904746#action_12904746
 ] 

Jack Krupansky commented on CONNECTORS-57:
------------------------------------------

This looks fine so far and should work for me.

If I understand the code, the Connector.noteJobComplete method is called when 
the job completes or is aborted and the SolrConnector.noteJobComplete 
implementation method unconditionally does a commit. That's fine my my use 
case, but we probably still want a connection option to disable that commit if 
the user has some other commit strategy in mind.

> Solr output connector option to commit at end of job, by default
> ----------------------------------------------------------------
>
>                 Key: CONNECTORS-57
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-57
>             Project: Apache Connectors Framework
>          Issue Type: Sub-task
>          Components: Lucene/SOLR connector
>            Reporter: Jack Krupansky
>
> By default, Solr will eventually commit documents that have been submitted to 
> the Solr Cell interface, but the time lag can confuse and annoy people. 
> Although commit strategy is a difficult issue in general, an option in LCF to 
> automatically commit at the end of a job, by default, would eliminate a lot 
> of potential confusion and generally be close to what the user needs.
> The desired feature is that there be an option to commit for each job that 
> uses the Solr output connector. This option would default to "on" (or a 
> different setting based on some global configuration setting), but the user 
> may turn it off if commit is only desired upon completion of some jobs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to