[ https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239993#comment-13239993 ]
Karl Wright commented on CONNECTORS-430: ---------------------------------------- For me it fails: {code} [junit] Multipart posting url 'http://localhost:8346/mcf-crawler-ui/execute.jsp' with parameters 'outputname=MyOutputConnection&index=&recrawlinterval=1440&description=MyJob&startmethod=2&expirationinterval=&jobid=1332885945254&priority=5&reseedinterval=60&tabname=Connection&connectionname=MyRepositoryConnection&schedulerecords=0&scheduletype=1&type=job&op=Continue' and 0 files... [junit] Traceback (most recent call last): [junit] File "test.py", line 166, in <module> [junit] var124.click() [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 120, in click [junit] self.get_form( ).execute_javascript_expression( self.onclick ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 672, in execute_javascript_expression [junit] return self.window_instance.execute_javascript_expression( javascript ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 920, in execute_javascript_expression [junit] return tokenstream.evaluate_expr( self.jscontext, "HTML" ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1085, in evaluate_expr [junit] rval = self.evaluate_expr1( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1120, in evaluate_expr1 [junit] rval = self.evaluate_expr2( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1164, in evaluate_expr2 [junit] return self.evaluate_expr3( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1176, in evaluate_expr3 [junit] rval = self.evaluate_expr4( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1264, in evaluate_expr4 [junit] rval = self.evaluate_expr5( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1299, in evaluate_expr5 [junit] rval = self.evaluate_expr6( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1341, in evaluate_expr6 [junit] return self.evaluate_expr7( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1438, in evaluate_expr7 [junit] return reference_object.call( arguments, context ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 554, in call [junit] return self.get_referenced_object().call(argset,context) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 186, in call [junit] response = ts.evaluate_statement( context, "method %s" % self.name ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 752, in evaluate_statement [junit] result = self.evaluate_statement( newscope, place ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 988, in evaluate_statement [junit] if self.evaluate_expr( context, place ) == None: [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1085, in evaluate_expr [junit] rval = self.evaluate_expr1( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1120, in evaluate_expr1 [junit] rval = self.evaluate_expr2( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1164, in evaluate_expr2 [junit] return self.evaluate_expr3( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1176, in evaluate_expr3 [junit] rval = self.evaluate_expr4( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1264, in evaluate_expr4 [junit] rval = self.evaluate_expr5( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1299, in evaluate_expr5 [junit] rval = self.evaluate_expr6( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1341, in evaluate_expr6 [junit] return self.evaluate_expr7( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1438, in evaluate_expr7 [junit] return reference_object.call( arguments, context ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 554, in call [junit] return self.get_referenced_object().call(argset,context) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 186, in call [junit] response = ts.evaluate_statement( context, "method %s" % self.name ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 752, in evaluate_statement [junit] result = self.evaluate_statement( newscope, place ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 810, in evaluate_statement [junit] rval = self.evaluate_statement( context, place ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 752, in evaluate_statement [junit] result = self.evaluate_statement( newscope, place ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 988, in evaluate_statement [junit] if self.evaluate_expr( context, place ) == None: [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1085, in evaluate_expr [junit] rval = self.evaluate_expr1( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1120, in evaluate_expr1 [junit] rval = self.evaluate_expr2( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1164, in evaluate_expr2 [junit] return self.evaluate_expr3( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1176, in evaluate_expr3 [junit] rval = self.evaluate_expr4( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1264, in evaluate_expr4 [junit] rval = self.evaluate_expr5( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1299, in evaluate_expr5 [junit] rval = self.evaluate_expr6( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1341, in evaluate_expr6 [junit] return self.evaluate_expr7( context, place, parse_only ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1438, in evaluate_expr7 [junit] return reference_object.call( arguments, context ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 554, in call [junit] return self.get_referenced_object().call(argset,context) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 1291, in call [junit] self.form_instance.submit( ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 706, in submit [junit] self.window_instance.execute_action( self.method, variables, files, self.action_url ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 928, in execute_action [junit] return self.browser_instance.execute_action( self.window_name, method, parameters, files, self.resolve( url ) ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 1069, in execute_action [junit] self.reload_window( window_name, window_data, url ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 1032, in reload_window [junit] self.build_window( window_name, window_data, old_window.get_parent_window( ), full_url, old_window.get_dialog_answers( ) ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 1038, in build_window [junit] new_window = VirtualWindow( self, window_name, window_data, parent_window, current_url ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 785, in __init__ [junit] parser.feed( data ) [junit] File "/usr/lib/python2.7/HTMLParser.py", line 109, in feed [junit] self.goahead(0) [junit] File "/usr/lib/python2.7/HTMLParser.py", line 153, in goahead [junit] k = self.parse_endtag(i) [junit] File "/usr/lib/python2.7/HTMLParser.py", line 327, in parse_endtag [junit] self.handle_endtag(tag.lower()) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 1497, in handle_endtag [junit] self.end_script( ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 1823, in end_script [junit] self.window_instance.accept_javascript( javascript_text ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/VirtualBrowser.py", line 965, in accept_javascript [junit] jstokens.evaluate_statement_list( self.jscontext ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 720, in evaluate_statement_list [junit] self.evaluate_statement( context, place ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 979, in evaluate_statement [junit] self.skip_statement( ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1017, in skip_statement [junit] self.skip_statement( ) [junit] File "/home/kwright/wip/trunk/tests/webcrawler/test-derby-output/Javascript.py", line 1053, in skip_statement [junit] raise Exception("Unexpected end of statement; need semicolon") [junit] Exception: Unexpected end of statement; need semicolon [junit] 2012-03-27 18:05:50.226:INFO::Stopped SocketConnector@0.0.0.0:8346 [junit] ------------- ---------------- --------------- [junit] Testcase: createConnectionsAndJob(org.apache.manifoldcf.webcrawler_tests.NavigationDerbyUI): Caused an ERROR [junit] UI test failed; error code: 1 [junit] java.lang.Exception: UI test failed; error code: 1 [junit] at org.apache.manifoldcf.core.tests.HTMLTester.executeTest(HTMLTester.java:183) [junit] at org.apache.manifoldcf.webcrawler_tests.NavigationDerbyUI.createConnectionsAndJob(NavigationDerbyUI.java:282) [junit] [junit] BUILD FAILED {code} This looks like an HTML tag issue - an end tag is not matched with a begin tag somewhere. > An error should be returned if invalid seeds are typed into the seeds list > for the web connector > ------------------------------------------------------------------------------------------------ > > Key: CONNECTORS-430 > URL: https://issues.apache.org/jira/browse/CONNECTORS-430 > Project: ManifoldCF > Issue Type: Improvement > Components: Web connector > Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3, > ManifoldCF 0.4, ManifoldCF 0.5 > Reporter: Erlend GarĂ¥sen > Assignee: Erlend GarĂ¥sen > Priority: Minor > Fix For: ManifoldCF 0.6 > > Attachments: CONNECTORS-430.patch > > > If you create a job for the web connector and enter an invalid URL into the > seeds list, any value is accepted. An error message should be returned to the > user in order to prevent invalid seeds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira