-----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Marcel Holtmann Sent: Monday, November 02, 2009 11:12 PM To: [email protected] Subject: Re: [PATCH 8/8] add new vpn scripts.
Hi Mohamed, > diff --git a/test/connect-provider b/test/connect-provider > new file mode 100755 > index 0000000..8771ff8 > --- /dev/null > +++ b/test/connect-provider > @@ -0,0 +1,29 @@ > +#!/usr/bin/python > + > +import sys > +import dbus > + > +if (len(sys.argv) < 4): > + print "Usage: %s <name> <host> <cookie> [cafile]" % (sys.argv[0]) > + sys.exit(1) I think if we call this connect-vpn it is better for now. [mabbas] ok > + > +print "Service path is %s" %(path) And it is Provider path ;) [mabbas] ok > diff --git a/test/list-provider b/test/list-provider > new file mode 100755 > index 0000000..d808fa0 > --- /dev/null > +++ b/test/list-provider > @@ -0,0 +1,27 @@ > +#!/usr/bin/python It should be named list-providers (plural). [mabbas] ok > diff --git a/test/remove-provider b/test/remove-provider > new file mode 100755 > index 0000000..2367f13 > --- /dev/null > +++ b/test/remove-provider > @@ -0,0 +1,22 @@ > +#!/usr/bin/python > + Leave this one out for now. And don't forget to update Makefile.am to include them via EXTRA_DIST. [mabbas] ok Regards Marcel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
