I don't know if this is really required, I did it before I changed my
app to cope with docs/service-api.txt description, but if it is worth,
apply, otherwise just forget :-)

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [email protected]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
From 266307330d1bea51ea7a479505d3da16fda6c325 Mon Sep 17 00:00:00 2001
From: Gustavo Sverzut Barbieri <[email protected]>
Date: Sat, 2 Jan 2010 18:57:12 -0200
Subject: [PATCH] Just return service error if state is "failure".

---
 src/service.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/service.c b/src/service.c
index ddb9fcb..7df7087 100644
--- a/src/service.c
+++ b/src/service.c
@@ -495,7 +495,10 @@ static DBusMessage *get_properties(DBusConnection *conn,
 		connman_dbus_dict_append_basic(&dict, "State",
 						DBUS_TYPE_STRING, &str);
 
-	str = error2string(service->error);
+	if (service->state == CONNMAN_SERVICE_STATE_FAILURE)
+		str = error2string(service->error);
+	else
+		str = NULL;
 	if (str != NULL)
 		connman_dbus_dict_append_basic(&dict, "Error",
 						DBUS_TYPE_STRING, &str);
-- 
1.6.0.4

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to