Hi Lucas, > I'd like to know why it is not possible to reorder services in > different states. I'm implementing this feature in EFL UI and it's a > bit weird not being able to re-order them. Looking at connman's > source, inside move_service() there's this check: > > if (target->state != service->state) > return __connman_error_invalid_service(msg); > > So, if the favorite service has a "failure" state while the other > (that i'm trying to put on top) is in "idle", i'm not able to reorder > them.
the idea is to only allow re-ordering for favorite services. However you are correct, the failure state makes this check pointless and wrong. Feel free to propose a patch fixing this. However one thing to keep in mind is that the top service is always having the default route. So it needs some extra care and can't be re-ordered against services that are not ready or online. Regards Marcel _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
