On Wed, Apr 14, 2010 at 12:30:02PM +0200, Marcel Holtmann wrote:
> Hi Daniel,
>
> > for ofono version >0.20
> > ---
> > plugins/ofono.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/plugins/ofono.c b/plugins/ofono.c
> > index 2ad01f2..10cc6d6 100644
> > --- a/plugins/ofono.c
> > +++ b/plugins/ofono.c
> > @@ -229,7 +229,7 @@ static void set_network_name_reply(DBusPendingCall
> > *call, void *user_data)
> > dbus_message_iter_next(&entry);
> > dbus_message_iter_recurse(&entry, &value);
> >
> > - if (g_str_equal(key, "Operator") == TRUE) {
> > + if (g_str_equal(key, "Name") == TRUE) {
> > const char *name;
> >
> > dbus_message_iter_get_basic(&value, &name);
>
> instead of just moving over to "Name" can you add statement to handle
> both. The old "Operator" and new "Name" property. That way we can
> support both oFono version. And just add a small comment to "Operator"
> handling that this is deprecated now. Then in the future we can easily
> remove it. However for at least a few ConnMan releases I do wanna
> support both.
Good idea. see v2.
> And there are a few more fields that have changed. Care to also add
> support for these?
Yep, if that's an easy thing to do, no problem.
daniel
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
