On Fri, Apr 16, 2010 at 10:09 AM, Forest Bond <for...@alittletooquiet.net> wrote: > Hi, > > On Fri, Apr 16, 2010 at 10:06:34AM -0700, Lucas De Marchi wrote: >> On Fri, Apr 16, 2010 at 9:46 AM, Forest Bond <for...@alittletooquiet.net> >> wrote: >> > diff --git a/test/test-connman b/test/test-connman >> > index aa781c3..2c0f4c6 100755 >> > --- a/test/test-connman >> > +++ b/test/test-connman >> > @@ -188,7 +188,7 @@ def device_handle(devices, interface): >> > disconnect_network(properties["Networks"], >> > value) >> > else: >> > print "Device has no networks" >> > - elif command in ["discconnect", "disc"]: >> > + elif command in ["disconnect", "disc"]: >> >> What version of connman are you using? > > Current git HEAD.
Humn... right. > Mine has this: > > elif command in ["disconnect", "disc"] and value != "": > if "Networks" in properties.keys(): > disconnect_network(properties["Networks"], value) > else: > print "Device has no networks" > elif command in ["discconnect", "disc"]: > if "Networks" in properties.keys(): > disconnect_network(properties["Networks"], "") > else: > print "Device has no networks" > > But note that this hasn't caused me any problems, I just noticed the bug while > reading the code. > I was just looking on the first condition. Since they take the same action, imho the best thing to do is to remove the second one. Lucas De Marchi _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
