Hi Daniel, On Tue, Jun 22, 2010 at 04:17:47PM +0200, Daniel Wagner wrote: > From: Daniel Wagner <daniel.wag...@bmw-carit.de> > > --- > src/connman.h | 4 ++++ > src/service.c | 11 +++++++++++ > 2 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/src/connman.h b/src/connman.h > index 8bf5e97..71a8609 100644 > --- a/src/connman.h > +++ b/src/connman.h > @@ -435,6 +435,10 @@ void __connman_service_append_nameserver(struct > connman_service *service, > void __connman_service_remove_nameserver(struct connman_service *service, > const char *nameserver); > > +void __connman_service_stats_timer_update(struct connman_service *service); > +struct connman_service_statistics *__connman_service_get_statistics( > + struct connman_service *service); > + As I said, I'd rather see 3 service accessors here instead of exporting the whole statistics structure.
> #include <connman/location.h> > > int __connman_location_init(void); > diff --git a/src/service.c b/src/service.c > index 4d0afc5..b9cb17d 100644 > --- a/src/service.c > +++ b/src/service.c > @@ -79,6 +79,7 @@ struct connman_service { > DBusMessage *pending; > guint timeout; > struct connman_location *location; > + struct connman_service_statistics stats; > }; > > static void append_path(gpointer value, gpointer user_data) > @@ -349,6 +350,16 @@ void __connman_service_remove_nameserver(struct > connman_service *service, > update_nameservers(service); > } > > +struct connman_service_statistics *__connman_service_get_statistics( > + struct connman_service *service) > +{ > + return &service->stats; > +} > + > +void __connman_service_stats_timer_update(struct connman_service *service) > +{ > +} > + Why do we need to define this one here ? It should be part of patch #6. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman