Hi Pekka, On Thu, Aug 19, 2010 at 08:14:00PM +0300, pekka.pe...@nokia.com wrote: > From: Pekka Pessi <pekka.pe...@nokia.com> > > --- > plugins/ofono.c | 28 ++++++++++++++++++---------- > 1 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/plugins/ofono.c b/plugins/ofono.c > index 8768eca..1ed4880 100644 > --- a/plugins/ofono.c > +++ b/plugins/ofono.c > @@ -320,7 +320,8 @@ static void set_network_name(struct connman_network > *network) > } > > dbus_pending_call_set_notify(call, set_network_name_reply, > - (void *)network, NULL); > + (void *)connman_network_ref(network), Unneeded cast.
> + (DBusFreeFunction)connman_network_unref); I don't really fancy this sort of cast. Please use a properly prototyped DBusFreeFunction or unref the network from set_network_name_reply(). > > done: > dbus_message_unref(message); > @@ -408,7 +409,8 @@ static void config_network(struct connman_network > *network, const char *path) > } > > dbus_pending_call_set_notify(call, config_network_reply, > - (void *)network, NULL); > + (void *)connman_network_ref(network), > + (DBusFreeFunction)connman_network_unref); Ditto. The rest looks good to me. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
