Hi Tomasz,
> I have been discussing about that issue with Patrick Flykt and
> since Jukka Rissanen's patch* has not been accepted I guess there
> are still rooms for ideas/patch around.
I must have spaced out on that one. Apologies for that.
> What about then expanding the current struct connman_ipdevice in
> ipdevice.c so that:
>
> struct connman_ipdevice {
> ...
>
> char *proxy;
> struct proxy_config *proxy_configuration;
>
> ...
> };
>
> where:
>
> struct proxy_config {
> union {
> char *pac;
> struct proxy_manual_config *manual;
> } config;
> };
>
> where:
>
> struct proxy_manual_config {
> char *http;
> uint16_t http_port;
> char https;
> uint16_t https_port;
>
> ... as Jukka proposed* in struct connman_manual_proxy ...
> };
>
>
> From DBus api point of view, it keeps the same as it is now + the manual
> config fields as Jukka proposed or would you prefer to get the manual
> config fields in there own dict inside Proxy dict.
> (a sub dict in a dict, is it really handy?)
I don't thing we need a sub dictionary for this. Just put the fields in
the proxy dictionary. I really have to catch up on this again since I
totally forgot about it. Please send a patch for API proposal again and
gonna have a look.
> In ipconfig.c this would just need to add support inside existing
> getters/setters. No big changes in the api at least.
>
> Anyway, what's the plan about pacrunner? As its name contains, I guess
> it targets only PAC files. So I guess, we do not have to care about it
> in case of manual config.
Actually initially I thought it should do auto-proxy only, but we will
use it for storing manual proxy configuration as well. It is just so
damn handy and works out pretty smoothly.
> What about libproxy, is there any plan yet on creating a module for
> connman in it?
I have a patch for libproxy to add pacrunner support. Actually libproxy
doesn't have to talk to ConnMan anymore. It just takes to pacrunner and
uses its FindProxyForURL method. Pretty simple.
That way libproxy can autostart pacrunner. And ConnMan already detects
when pacrunner starts and loads the proxy configuration into it.
It works so nicely that I am regretting not having done this a year ago,
but I just had time to start thinking about the whole proxy problem.
And pacrunner is not ConnMan specific. Every other system component is
able to use it. It is even useful for a desktop running NetworkManager.
Regards
Marcel
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
