Hi Patrik, On Thu, Dec 02, 2010 at 04:09:11PM +0200, [email protected] wrote: > From: Patrik Flykt <[email protected]> > > Hi, > > This patch set implements Agent API ReportError method call. v2 is updated to > use D-Bus name net.connman. v3 updates a structure and function name and > calls connman_profile_changed() when not retrying. > > Error names have been updated to use an net.connman.Agent prefix, as object > paths were found not to be a valid component in an error name. A > 'service_complete' helper function has been created, it is needed later on in > the patch set. > > __connman_agent_report_error has been implemented taking a callback function > and user data argument. A ReportError method call is created and sent, and > the specified Error.Retry D-Bus error is used to decide whether to retry the > same service or not. > > The error reporting functionality is triggered from service.c for a service > state set to CONNMAN_SERVICE_STATE_FAILURE. Error strings are created with > error2string. > > Finally there is ReportError support for test/simple-agent. All 4 patches applied, thanks a lot. I also added a scan initialisation from your report_error callback, when we don't want to retry. This is needed for atoconnect purposes, and is currently done by __connman_service_indicate_state()
Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
