> -----Original Message-----
> From: Samuel Ortiz [mailto:sa...@linux.intel.com]
> Sent: Wednesday, December 08, 2010 6:59 PM
> To: Xu, Martin
> Cc: connman@connman.net
> Subject: Re: [PATCH 3/4] call __connman_technology_add_interface() after
> rtnl->newlink()
>
> Hi Martin,
>
> On Fri, Dec 03, 2010 at 07:06:49PM +0800, martin...@intel.com wrote:
> > From: Martin Xu <martin...@intel.com>
> >
> > The device is created and attach technology at rtnl->newlink(), so
> > __connman_technology_add_interface() nees to be called after
> rtnl->newlink()
> Thanks for the more detailed explanation. I have one more comment though:
>
> > @@ -446,7 +447,6 @@ static void process_newlink(unsigned short type, int
> index, unsigned flags,
> >
> > if (g_hash_table_lookup(interface_list,
> > GINT_TO_POINTER(index)) == NULL) {
> Please do a:
> interface = (g_hash_table_lookup(interface_list, GINT_TO_POINTER(index));
> if (interface == NULL) {
> [...]
> }
That fairly make sense. :-)
_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
