Hi Daniel, On Thu, Jan 27, 2011 at 01:34:52PM +0100, Daniel Wagner wrote: > From: Daniel Wagner <[email protected]> > > WIP A few comments on this patch:
- I'd prefer connman_dhcp_start/stop() to carry a callback function as an argument. This way the network call from dhcp would just be a dhcp->callback() one, not a hardcoded connman_network_ one. - The link between this code and the whole connection.c nuclear plant is missing. i.e. we're no longer keeping track of all gateways and are always assigning a default gateway from __connman_network_set_dhcp_valid(). This won't work with multiple connections and VPNs. You'll be defining multiple default gateways, with no particular priorities. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
