Hi Samual,
On Fri, Feb 11, 2011 at 08:22:25PM +0100, Samuel Ortiz wrote:
> Hi Daniel,
>
> On Wed, Feb 09, 2011 at 12:03:49PM +0100, Daniel Wagner wrote:
> > From: Daniel Wagner <daniel.wag...@bmw-carit.de>
> >
> > __connman_service_append/remove_namerserver() is renamed to
> > __connman_service_nameserver_append/remove to be more consistent with
> > the other Service API naming. Also the semantic changes to
> > append/remove instead of set/clear.
> >
> > The list of configured nameservers takes preference over the list of
> > discovered (DHCP, VPN, ...) nameservers.
> It looks better now. I still have some minor comments though:
>
>
> > @@ -403,32 +410,132 @@ static void update_nameservers(struct
> > connman_service *service)
> > connman_resolver_flush();
> > }
> >
> > -void __connman_service_append_nameserver(struct connman_service *service,
> > +static int nameserver_append(char ***nameservers, const char *nameserver)
> I would prefer this one to simply take a service pointer and the nameserver
> pointer as arguments.
Sure, this was a left over when both nameservers and
nameservers_config was modifed int nameserver_append/remove. This is
not needed. I have merge nameserver_append/remove into
__connman_service_nameserver_append/remove.
> > +static void nameserver_add_routes(int index, char ***nameservers,
> > + const char *gw)
> > +{
> > + char **servers;
> > + int i;
> > +
> > + servers = *nameservers;
> > +
> > + for (i = 0; servers[i] != NULL; i++) {
> > + if (connman_inet_compare_subnet(index, servers[i]))
> > + continue;
> > +
> > + connman_inet_add_host_route(index, servers[i], gw);
> > + }
> > +}
> > +
> > +static void nameserver_del_routes(int index, char ***nameservers)
> > +{
> > + char **servers;
> > + int i;
> > +
> > + servers = *nameservers;
> > +
> > + for (i = 0; servers[i] != NULL; i++)
> > + connman_inet_del_host_route(index, servers[i]);
> For those 2 routines, you just need a **namservers pointer (not ***).
Yep, no excuses for this one...
Thanks for the review. The update is coming soon.
cheers,
daniel
_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
