Hi Jukka,

On Mon, Feb 21, 2011 at 03:38:24PM +0200, Jukka Rissanen wrote:
> ---
>  Makefile.am  |    8 +-
>  configure.ac |    4 +
>  src/6to4.c   |  220 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 228 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 8f13f56..5d808a6 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -79,7 +79,7 @@ src_connmand_SOURCES = $(gdbus_sources) $(gdhcp_sources) \
>                       src/session.c src/tethering.c src/wpad.c src/wispr.c \
>                       src/stats.c src/iptables.c src/dnsproxy.c src/6to4.c
>  
> -src_connmand_LDADD = $(builtin_libadd) @GLIB_LIBS@ @DBUS_LIBS@ \
> +src_connmand_LDADD = $(builtin_libadd) @GLIB_LIBS@ @GIO_LIBS@ @DBUS_LIBS@ \
>                               @CAPNG_LIBS@ @XTABLES_LIBS@ -lresolv -ldl
>  
>  src_connmand_LDFLAGS = -Wl,--export-dynamic \
> @@ -103,9 +103,9 @@ build_plugindir = $(plugindir)
>  build_scriptdir = $(scriptdir)
>  endif
>  
> -AM_CFLAGS = @DBUS_CFLAGS@ @GLIB_CFLAGS@ @CAPNG_CFLAGS@ @XTABLES_CFLAGS@ \
> -                             @NETLINK_CFLAGS@ @GNUTLS_CFLAGS@ \
> -                             $(builtin_cflags) \
> +AM_CFLAGS = @DBUS_CFLAGS@ @GLIB_CFLAGS@ @GIO_CFLAGS@ @CAPNG_CFLAGS@ \
> +                              @XTABLES_CFLAGS@ @NETLINK_CFLAGS@ \
> +                              @GNUTLS_CFLAGS@ $(builtin_cflags) \
>                               -DCONNMAN_PLUGIN_BUILTIN \
>                               -DSTATEDIR=\""$(statedir)"\" \
>                               -DPLUGINDIR=\""$(build_plugindir)"\" \
> diff --git a/configure.ac b/configure.ac
> index 216c47b..709902a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -304,6 +304,10 @@ if (test "${enable_threads}" = "yes"); then
>       GLIB_LIBS="$GLIB_LIBS $GTHREAD_LIBS"
>  fi
>  
> +PKG_CHECK_MODULES(GIO, gio-2.0 >= 2.22.2)
> +AC_SUBST(GIO_CFLAGS)
> +AC_SUBST(GIO_LIBS)
> +
So I think this patch should be rewritten to use the gweb APIs. It would be a
lot cleaner. It will take care of the resolving parts for example.
The "only" missing piece is a proper IPv6 gweb support. Would you be ok
with looking at that ? 

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

Reply via email to