Hi Samuel,
On 06/21/2011 07:10 PM, Samuel Ortiz wrote:
Hi Jukka,
On Mon, Jun 20, 2011 at 02:05:23PM +0300, Jukka Rissanen wrote:
---
include/ipconfig.h | 1 +
src/connection.c | 495 ++++++++++++++++++++++++++++++++++++++++------------
src/connman.h | 9 +-
src/ipconfig.c | 18 +-
src/network.c | 3 +-
5 files changed, 397 insertions(+), 129 deletions(-)
Pretty good patch, I have one comment though:
Thanks, I tried to test the patch as well as possible but my test setup
is quite limited atm so I could not test the VPN connectivity for example.
-static struct gateway_data *find_gateway(int index, const char *gateway)
+static struct gateway_data *find_gateway(int index, const char *gateway,
+ struct gateway_config **config)
Couldn't this one simply return a struct gateway_config * ?
Yes, you are right. I can fix that.
Cheers,
Samuel.
Jukka
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
