Hi Daniel,

On 07/22/2011 12:57 PM, Daniel Wagner wrote:
Hi Jukka,

On Wed, Jul 20, 2011 at 10:30:38AM +0300, Jukka Rissanen wrote:
From: Mohamed Abbas<mab...@linux.intel.com>

Initial revision.
---
  plugins/pptp.c |  278 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  1 files changed, 278 insertions(+), 0 deletions(-)
  create mode 100644 plugins/pptp.c

+               if (!strcmp(key, "INTERNAL_IP4_ADDRESS"))
+                       connman_provider_set_string(provider, "Address", value);
+
+               if (!strcmp(key, "INTERNAL_IP4_NETMASK"))
+                       connman_provider_set_string(provider, "Netmask", value);
+
+               if (!strcmp(key, "INTERNAL_IP4_DNS"))
+                       connman_provider_set_string(provider, "DNS", value);
+
+               if (!strcmp(key, "INTERNAL_IFNAME"))
+                       ifname = (char *)g_strdup(value);
+
+               dbus_message_iter_next(&dict);
+       }

I had a look what we are doing in openvpn.c here.  We have there following 
sequence:

   connman_ipaddress_set_ipv4(ipaddress, address, NULL, gateway);
   connman_ipaddress_set_peer(ipaddress, peer);
   connman_provider_set_ipaddress(provider, ipaddress);

   connman_provider_set_nameservers(provider, nameservers);

Also there is some nameserver handling code there. Don't we have to do
this here too?

Address setting is done in patch #15 for pptp and patch #11 for l2tp.

cheers,
daniel



Jukka

_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

Reply via email to