Hi Jukka, On 07/22/2011 12:27 PM, Jukka Rissanen wrote: > Hi Daniel, > > On 07/22/2011 01:19 PM, Daniel Wagner wrote: >> Hi Jukka, >>> @@ -187,14 +193,39 @@ static int l2tp_notify(DBusMessage *msg, struct >>> connman_provider *provider) >>> > ... >>> + >>> + g_free(addressv4); >>> + g_free(netmask); >>> + g_free(gateway); >>> + connman_ipaddress_free(ipaddress); >> >> Here is the code I was missing. Wouldn't it make sense to merge this >> patch? Or do you want to keep it clear how has written which part? >> >> cheers, >> daniel >> > > I was thinking that I could fix the nitpicks (code style etc minor > issues) in the original patches but bug fixes would go to separate patches.
I see. Well, I'm fine with either solution. I realize I haven't really read what you wrote in your cover letter. Sorry about that. cheers, daniel _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
