Hi Samuel, >-----Original Message----- >From: Samuel Ortiz [mailto:[email protected]] >Sent: Tuesday, August 16, 2011 5:59 PM >To: Wang, Yu A >Cc: [email protected] >Subject: Re: [PATCH 2/4] connection: Fix vpn on network without gateway server > >Hi Arron, > >On Fri, Aug 12, 2011 at 02:43:17AM -0400, Yu A Wang wrote: >> @@ -266,6 +268,9 @@ static void set_default_gateway(struct gateway_data >*data, >> data->ipv4_gateway->vpn == TRUE) { >> connman_inet_set_gateway_address(data->index, >> data->ipv4_gateway->vpn_ip); >> + connman_inet_add_host_route(data->ipv4_gateway->vpn_phy_index, >> + data->ipv4_gateway->vpn_ip, >> + data->ipv4_gateway->vpn_phy_ip); >For regular setups (e.g. VPN over WiFi), how will that host route look like ? >Can you confirm that you have also tested those regular setup with this patch? Ok, I have checked 3G service with both mbm and ppp modem, I'll double check
VPN over Ethernet and WiFi
>> @@ -513,9 +523,16 @@ int __connman_connection_gateway_add(struct
>connman_service *service,
>> else if (gateway != NULL)
>> new_gateway->ipv4_gateway->vpn_ip =
>> g_strdup(gateway);
>> - if (active_gateway)
>> + if (active_gateway) {
>> + if (active_gateway->ipv4_gateway->gateway !=
NULL &&
>>
>You have several over 80 chars line here, could you please fix this up ?
Yes I know several lines are over 80 chars, but it seems will break
indentation rule
if we keep not more than 80 chars rule:-(
Thanks
Arron
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
