Hi Samuel,

>-----Original Message-----
>From: Samuel Ortiz [mailto:[email protected]]
>Sent: Tuesday, August 16, 2011 5:59 PM
>To: Wang, Yu A
>Cc: [email protected]
>Subject: Re: [PATCH 4/4] task: Cleanup signal mask at task_setup
>
>Hi Arron,
>
>On Fri, Aug 12, 2011 at 02:44:00AM -0400, Yu A Wang wrote:
>> @@ -268,9 +270,14 @@ static void task_died(GPid pid, gint status,
gpointer
>user_data)
>>
>>  static void task_setup(gpointer user_data)
>>  {
>> +    sigset_t mask;
>>      struct connman_task *task = user_data;
>>
>>      DBG("task %p", task);
>> +
>> +    sigemptyset(&mask);
>> +    if (sigprocmask(SIG_SETMASK, &mask, NULL) < 0)
>> +            perror("Failed to clean signal mask");
>Can't we use connman_error here ? I know this will be called from the
forked
>process, but we still could use the ConnMan log routines.
I'll fix it and resubmit, thanks

Thanks
Arron

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to