This is needed as the default routes are not set properly
if we allow a service to be moved before a VPN service.
---
Hi,

it would be nice to allow a service to be moved before VPN service
but unfortunately it would require bigger changes in connection.c
so atm just disallow this.

Jukka


 src/service.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/service.c b/src/service.c
index fab0cd7..8152b73 100644
--- a/src/service.c
+++ b/src/service.c
@@ -2916,7 +2916,8 @@ static DBusMessage *move_service(DBusConnection *conn,
                return __connman_error_not_supported(msg);
 
        target = find_service(path);
-       if (target == NULL || target->favorite == FALSE || target == service)
+       if (target == NULL || target->favorite == FALSE || target == service ||
+                               target->type == CONNMAN_SERVICE_TYPE_VPN)
                return __connman_error_invalid_service(msg);
 
        target4 = __connman_ipconfig_get_method(target->ipconfig_ipv4);
-- 
1.7.1

_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

Reply via email to