Hi Marcel, On 19.04.2012 10:37, Marcel Holtmann wrote: >> This fixes a small regression with the AutoConnect changes on ethernet. >> If the user has used ConnMan in the past and updates to the recent version >> the settings files wont contain the AutoConnect key value pair. Then >> we do not enable the auto connect. >> --- >> src/service.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/service.c b/src/service.c >> index 8f97c09..ed64133 100644 >> --- a/src/service.c >> +++ b/src/service.c >> @@ -407,6 +407,8 @@ static int service_load(struct connman_service *service) >> service->identifier, "AutoConnect", &error); >> if (error == NULL) >> service->autoconnect = autoconnect; >> + else >> + service->autoconnect = TRUE; > > shouldn't this be using the default value or the settings from main.conf > depending on the technology?
service_load() is called after the update from the main.conf. So it overwrites the main.conf settings. Sounds reasonable for me, that the per service settings have higher precedence then the main.conf ones. cheers, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
