Hi Tomasz, > This patch fixes this: > GLib-CRITICAL **: g_sequence_sort_changed: assertion `!is_end (iter)' failed > > --- > Hi, > > It seems that glib prints out this message when there is less than 1 sequence > iter to sort. > Looks awkward, but checking the length of sequence fixes the issue (we sort > it only if it owns >= 2 items) > > @Patrik: I am not fully sure about the part in > __connman_service_set_favorite(): should service_schedule_changed() be called > even if sequence was not resorted?
as far as I read it, we should not send a services changed signal if the order does not change. It is up to the property changed for that service to be signaled. We can do further optimization to this in some later releases. So I went ahead and applied your patch. Regards Marcel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
