Hi,

On Tue, 2012-06-12 at 16:44 +0200, elena.tebe...@gmail.com wrote:
>  int connman_network_set_nameservers(struct connman_network *network,
> -                             const char *nameservers)
> +                             const char *nameservers, connman_bool_t append)
>  {
>       struct connman_service *service;
>       char **nameservers_array;
> @@ -1773,7 +1773,8 @@ int connman_network_set_nameservers(struct 
> connman_network *network,
>       if (service == NULL)
>               return -EINVAL;
>  
> -     __connman_service_nameserver_clear(service);
> +     if (append == FALSE)
> +             __connman_service_nameserver_clear(service);
>  
>       if (nameservers == NULL)
>               return 0;

Instead of adding a parameter here, I'd keep the function as is and go
for concatenating the IPv4 and IPv6 nameservers in the calling function.
It seems that ofono ipv4ipv6 PDP context asynchronously sends IPv4 and
IPv6 information in some order, right?

Cheers,

        Patrik


_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

Reply via email to