Hi, v5: - patch order changed - new patch (#4) that replaces dhcp_add_simple_option() with three variants for different data sizes (uint8, uint16 and uint32)
v4: - remove inclusion guard from header file (#1) - really remove unneccesary cast in client.c (#2) - use host byte order internally (#2) - changed option_u8 to option (#2) - remove obsolete function (#3) v3: - use unalignment macros from Bluez (#1) - remove unnecessary cast in client.c (#2) - add comment in client.c (#2) Patch #1 remove obsolete function Patch #2 creates put|get_unaligned and get_[b|l]e* macros which can convert between big-endian or little-endian values. Patch #3 adds the alignment macros into gdhcp code. Patch #4 replaces option setting function (dhcp_add_simple_option) with three variants for setting uint8, uint16 and uint32 values. Patch #5 downgrades cast-align and unused-value errors into warnings so that we can compile connman using clang. Eventually we should either change connman code or do some voodoo magic with clang and enable the errors back. Cheers, Jukka Jukka Rissanen (5): gdhcp: Remove obsolete load lease function gdhcp: Add unalignment macros gdhcp: Use host byte order internally gdhcp: Use data size specific option setting function build: Ignore cast-align and unused-value errors if clang is used Makefile.am | 2 +- configure.ac | 6 ++ gdhcp/client.c | 58 +++++++++---------- gdhcp/common.c | 67 ++++++++++++++++++---- gdhcp/common.h | 23 ++------ gdhcp/gdhcp.h | 2 - gdhcp/ipv4ll.c | 4 +- gdhcp/server.c | 54 ++++++++---------- gdhcp/unaligned.h | 163 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 9 files changed, 284 insertions(+), 95 deletions(-) create mode 100644 gdhcp/unaligned.h -- 1.7.11.4 _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
