From: Patrik Flykt <patrik.fl...@linux.intel.com>

        Hi,

Updated patch 03 to handle reality better, as data->cb_data is already known
to be NULL, don't check it another time. Also don't send anything if the
user_data struct cannot be allocated.


Cheers,

        Patrik


Here are a few fixes for bug #25890. The patches below allow -EINPROGRESS
to be passed through to the D-Bus client (patch 01) and returns the two most
used errors to the D-Bus client via the callback function (patch 02). A fix
for waiting until both configure and connect is completed is also provided
(patch 03).

I have to investigate if patch 03 should actually be handled in provider.c
when implemented properly, but for now patch 03 is ok and will work.

In addition to these patches, the script in bug #25890 needs updating. It
can receive an error of net.connman.Error.InProgress if the VPN was already
connecting and net.connman.Error.AlreadyConnected if already connected.
The script needs to catch a 'DBusException' and inspect its
'_dbus_error_name' variable against the values above. With this patch set
and those script modifications ConnectProvider should start working.


Patrik Flykt (3):
  manager: -EINPROGRESS is a valid response for ConnectProvider
  vpn-plugin: Propagate most common errors to callback function
  vpn-plugin: Check completion of configure and connect

 plugins/vpn.c |   48 ++++++++++++++++++++++++++++--------------------
 src/manager.c |    8 +-------
 2 files changed, 29 insertions(+), 27 deletions(-)

-- 
1.7.10.4

_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

Reply via email to