Hi,

On 08.01.2013 11:32, patrik.fl...@linux.intel.com wrote:
From: Patrik Flykt <patrik.fl...@linux.intel.com>

Although it seems wpa_supplicant can handle 4 SSIDs in version 0.7.x
and 16 starting with 0.8.x, in practise this does not work. Thus
return the value reported without relying on wpa_supplicant internals
to handle the situation.
---

At least the supplicant.c part should apply to almost any usable version
of ConnMan. Please report if this fix works.

Cheers,

        Patrik


  gsupplicant/gsupplicant.h |    9 ---------
  gsupplicant/supplicant.c  |    3 ---
  2 files changed, 12 deletions(-)

diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h
index 790cfed..1b1fce2 100644
--- a/gsupplicant/gsupplicant.h
+++ b/gsupplicant/gsupplicant.h
@@ -138,15 +138,6 @@ struct _GSupplicantSSID {

  typedef struct _GSupplicantSSID GSupplicantSSID;

-/*
- * Max number of SSIDs that can be scanned.
- * In wpa_s 0.7x the limit is 4.
- * In wps_s 0.8 or later it is 16.
- * The value is only used if wpa_supplicant does not return any max limit
- * for number of scannable SSIDs.
- */
-#define WPAS_MAX_SCAN_SSIDS 4
-

We should probably set the max value to 1 if supplicant returns 0 or does not return any value, as otherwise we might have some issues when trying to autoconnect a hidden network.


  struct scan_ssid {
        unsigned char ssid[32];
        uint8_t ssid_len;
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index d9dfdbb..9aa951d 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -764,9 +764,6 @@ unsigned int g_supplicant_interface_get_max_scan_ssids(
        if (interface == NULL)
                return 0;

-       if (interface->max_scan_ssids == 0)
-               return WPAS_MAX_SCAN_SSIDS;
-
        return interface->max_scan_ssids;
  }



Cheers,
Jukka



_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

Reply via email to