Re: [PATCH] gsupplicant: Set the scan callback in g_supplicant_interface_scan

[Julien Massot]

Hi Patrick, Tomasz

On Fri, Feb 22, 2013 at 11:58 AM, Tomasz Bursztyka
<tomasz.burszt...@linux.intel.com> wrote:
> Nice catch!

Thanks, this bug gave me some hard time :),

I'm also thinking that we need a little cleanup in supplicant.c about
the scan, callback, and user_data.
Some pointers are reduntant or confusing.

especially in g_supplicant_interface_scan and interface_scan_result:

int g_supplicant_interface_scan(GSupplicantInterface *interface,
                                GSupplicantScanParams *scan_data,
                                GSupplicantInterfaceCallback callback,
                                                        void *user_data)
{
...
        data->interface = interface;
        data->callback = callback;
        data->user_data = user_data;
        data->scan_params = scan_data;

        interface->scan_callback = callback;
        interface->scan_data = user_data;
...
}

and in
static void interface_scan_result(const char *error,
                                DBusMessageIter *iter, void *user_data)
{
...
data->interface->scan_callback = data->callback;
data->interface->scan_data = data->user_data;
...
}

Regards,
Julien
_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman