Hi Tomasz,

On 22.02.2013 15:31, Tomasz Bursztyka wrote:
+static int recover_2b_from_tlv(const uint8_t *tlv_msg, uint16_t *val)
+{
+       uint16_t ne_val;
+       uint8_t *rec;
+
+       rec = (uint8_t *) &ne_val;
+       rec[0] = tlv_msg[0];
+       rec[1] = tlv_msg[1];
+
+       *val = htons(ne_val);
+
+       return 2;
+}

Could we just say

        ne_val = tlv_msg[0] | tlv_msg[1] << 8;

here and avoid the rec pointer?

or even shorter

        *val = htons(tlv_msg[0] | tlv_msg[1] << 8);


Cheers,
Jukka


_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

Reply via email to