On Tue, 2013-03-12 at 18:16 +0100, Daniel Wagner wrote: > From: Daniel Wagner <daniel.wag...@bmw-carit.de> > > Hi, > > There are only two small changes in v7. I think this should now be > the final version. I am testing it also with the firewall.c code > on top of it and it looks pretty good right now. If possible I would > like to see this version now applied :) > > build: Ignore iptables-unit and session-test in tools directory > > updates .gitignore after moving two binaries two tools > > iptables: Fix invalid access to list after removing first rule > iptables: Factor out duplicated update hook code > > There was a small hickup (incl.) a bug in hidden when deleting > a rule. If that rule was the first of a builtin chain we accessed > an invalid pointer.
Applied patches 1,2,4-7,9-16. Thanks! For patch #3 the same pretty-print as for the existing tests should be used and for patch #8 #ifdef should be removed in favor of debug printouts complaining that iptables-save is missing. Cheers, Patrik > cheers, > daniel > > > Daniel Wagner (16): > test-iptables: Move file to tools and rename it to iptables-unit > test-session: Move file to tools and rename it to session-test > test-ippool: Run it during make distcheck > build: Ignore iptables-unit and session-test in tools directory > iptables: Add __connman_iptables_dump() > iptables-test: Use iptables implementation from core > iptables-unit: Add debug option > iptables-unit: Check if rules are inserted/removed > iptables: Drop support for xtables < 1.4.11 > iptables: Use glib function for string operations > iptables: Lookup in table hash before module loading > iptables: Improve debug log output > iptables: Rename pre_load_table() to get_table() > iptables: Fix invalid access to list after removing first rule > iptables: Factor out duplicated update hook code > iptables: Allocated memory blocks are already zerod out > > .gitignore | 4 +- > Makefile.am | 36 +- > configure.ac | 8 +- > src/connman.h | 1 + > src/iptables.c | 293 ++++---- > tools/iptables-test.c | 1898 > +++---------------------------------------------- > tools/iptables-unit.c | 476 +++++++++++++ > tools/manager-api.c | 262 +++++++ > tools/session-api.c | 330 +++++++++ > tools/session-test.c | 588 +++++++++++++++ > tools/session-test.h | 145 ++++ > tools/session-utils.c | 261 +++++++ > unit/manager-api.c | 262 ------- > unit/session-api.c | 330 --------- > unit/test-connman.h | 145 ---- > unit/test-iptables.c | 327 --------- > unit/test-session.c | 588 --------------- > unit/utils.c | 261 ------- > 18 files changed, 2301 insertions(+), 3914 deletions(-) > create mode 100644 tools/iptables-unit.c > create mode 100644 tools/manager-api.c > create mode 100644 tools/session-api.c > create mode 100644 tools/session-test.c > create mode 100644 tools/session-test.h > create mode 100644 tools/session-utils.c > delete mode 100644 unit/manager-api.c > delete mode 100644 unit/session-api.c > delete mode 100644 unit/test-connman.h > delete mode 100644 unit/test-iptables.c > delete mode 100644 unit/test-session.c > delete mode 100644 unit/utils.c > _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman