On Tue, 2013-04-02 at 13:56 +0200, Daniel Wagner wrote:
> Hi Patrik,
>
> again nitpicking :)
>
> On 04/02/2013 12:34 PM, Patrik Flykt wrote:
> > +void __connmanctl_save_rl(void)
> > +{
> > + if (interactive == false)
> > + return;
> > +
> > + save_input = !RL_ISSTATE(RL_STATE_DONE);
> > +
> > + if (save_input) {
> > + saved_point = rl_point;
> > + saved_line = rl_copy_text(0, rl_end);
> > + rl_save_prompt();
> > + rl_replace_line("", 0);
> > + rl_redisplay();
> > + }
> > +}
>
> I understand we are going to adopt also oFono/BlueZ style for bools etc.
> Should the first if read the more like
>
> if (!interactive)
> return;
>
> ?
Thanks for the head up on this, I decided to leave it as is.
Cheers,
Patrik
_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
