Hi,
For version 2 of this patch set only patch 5/6 survived and appears now
as patch 1/5. The other patches are totally rewritten.
As only one ipconfig can be set at a time via D-Bus, the code for
connecting and disconnecting ipconfigs has been factored out to allow
this new usage (patches 01 and 02).
The newly factored out code is used by
__connman_network_{set,clear}_ipconfig (patches 05 and 06). These
functions also check that the network is connected before attempting to
proceed. The main reason of the refactoring is to get rid of duplicate
code so that the ipconfig is connected and disconnected in one place only.
Enabling the new code is removed from its previous location (patch 05)
into __connman_service_reset_ipconfig right after the release of the
previously used ipconfig.
This time around the function names have been left as is, it might be
easier to review these changes in this case.
Please review,
Patrik
Patrik Flykt (6):
service: The existing ipconfig is unmodified if error is reported
network: Factor out ipconfig disconnection
network: Factor out ipconfig connecting
network: Use factored out ipconfig disconnection
network: Use factored out ipconfig connection code
service: Handle re-enabling of the new ipconfig
src/connman.h | 3 +-
src/network.c | 326 +++++++++++++++++++++++----------------------------------
src/service.c | 24 ++---
3 files changed, 145 insertions(+), 208 deletions(-)
--
1.7.10.4
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
