Hi,

On Wed, 2014-01-29 at 09:41 -0500, Glenn Schmottlach wrote:
> From: Glenn Schmottlach <[email protected]>
> 
> Separate Linux Gadget device support into a separate plug-in instead
> of being combined with the Ethernet plug-in.

Mention renaming of ethernet functions also.
 
> -static struct connman_network_driver cable_driver = {
> -     .name           = "cable",
> -     .type           = CONNMAN_NETWORK_TYPE_ETHERNET,
> -     .probe          = cable_probe,
> -     .remove         = cable_remove,
> -     .connect        = cable_connect,
> -     .disconnect     = cable_disconnect,
> +static struct connman_network_driver eth_network_driver = {
> +     .name                   = "cable",
> +     .type                   = CONNMAN_NETWORK_TYPE_ETHERNET,
> +     .probe          = eth_network_probe,
> +     .remove         = eth_network_remove,
> +     .connect        = eth_network_connect,
> +     .disconnect     = eth_network_disconnect,
>  };


> -static struct connman_technology_driver tech_driver = {
> -     .name                   = "cdc_ethernet",
> -     .type                   = CONNMAN_SERVICE_TYPE_GADGET,
> -     .probe                  = tech_probe,
> -     .remove                 = tech_remove,
> -     .add_interface          = tech_add_interface,
> -     .remove_interface       = tech_remove_interface,
> -     .set_tethering          = tech_set_tethering,
> +static struct connman_device_driver eth_dev_driver = {
> +     .name                   = "ethernet",
> +     .type                   = CONNMAN_DEVICE_TYPE_ETHERNET,
> +     .probe          = eth_dev_probe,
> +     .remove         = eth_dev_remove,
> +     .enable         = eth_dev_enable,
> +     .disable        = eth_dev_disable,
>  };
 
> -static struct connman_technology_driver eth_driver = {
> -     .name                   = "ethernet",
> -     .type                   = CONNMAN_SERVICE_TYPE_ETHERNET,
> -     .probe                  = eth_probe,
> -     .remove                 = eth_remove,
> -     .add_interface          = eth_add_interface,
> -     .remove_interface       = eth_remove_interface,
> -     .set_tethering          = eth_set_tethering,
> +static struct connman_technology_driver eth_tech_driver = {
> +     .name                                                   = "ethernet",
> +     .type                                                   = 
> CONNMAN_SERVICE_TYPE_ETHERNET,
> +     .probe                                          = eth_tech_probe,
> +     .remove                                         = eth_tech_remove,
> +     .add_interface          = eth_tech_add_interface,
> +     .remove_interface       = eth_tech_remove_interface,
> +     .set_tethering          = eth_tech_set_tethering,
>  };

Indentation...?
 
> +static struct connman_technology_driver gadget_tech_driver = {
> +     .name                                                   = 
> "cdc_ethernet",
> +     .type                                                   = 
> CONNMAN_SERVICE_TYPE_GADGET,
> +     .probe                                          = gadget_tech_probe,
> +     .remove                                         = gadget_tech_remove,
> +     .add_interface          = gadget_tech_add_interface,
> +     .remove_interface       = gadget_tech_remove_interface,
> +     .set_tethering          = gadget_tech_set_tethering,
> +};

Same here.

        Patrik

_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to