Hi,
On Fri, 2014-02-07 at 14:02 +0100, Daniel Wagner wrote:
> The main
> objection in v2 was that I had to track all services in session.c via
> the notify API. That is not needed in v3 as we live can update the
> association directly here. service.c assigns services to sessions in
> patch 7 by iterating over the service list. How should session.c know
> which services are there if it is not tracking them?
The main objection against the notifiers in v2 was the to my
understanding unnecessary tracking of all services independent of
service state. I.e. service_add and service_remove members of struct
connman_notifier should not be needed. Less services need to be tracked
if service_state_changed is implemented and only the services in ready
and online state are remembered in a service hash in src/session.c.
Does this make it any clearer or am I forgetting some detail regarding
service handling/iteration that cannot be exported from service.c?
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
