Hi Aaron, On 03/04/2014 03:26 AM, Aaron McCarthy wrote: > Hi, > > I have been using the data counters API and have noticed that the > implementation uses 32 bit data types throughout. For the bytes received and > transmitted this means that the values wrap once 4GB has been transferred. > The > other fields are less likely to wrap so soon.
Yep, that is likely to happen. > The attached patch changes it to use 64 bit data. Currently it makes no > attempt to maintain compatibility as both the format of the data file and the > DBus API changes. I see little advantage in maintaining compatibility with > the > data file. I agree. Maybe one option would to have a small migration tool. E.g. there is under tools a program called stats-tool.c which could be doing this. If you are it, I would not mind having it updated to u64 too :) > The data type of the counter fields are not documented in the > counter-api.txt file. Depending on how the demarshaller is implemented this > type change is potentially handled automatically. Extending the DBus > interface > (instead of just changing the signature) is easy enough. Okay, sounds reasonable to me. I don't have a problem with this. > Any feedback or suggestions would be appreciated. Looks great. Sorry for having implemented only u32, it seems I wanted to repeat famous face plans :) cheers, daniel _______________________________________________ connman mailing list [email protected] https://lists.connman.net/mailman/listinfo/connman
