Hi,

+++ b/src/service.c
@@ -4022,8 +4022,10 @@ static DBusMessage *connect_service(DBusConnection *conn,
        if (err == -EINPROGRESS)
                return NULL;
- dbus_message_unref(service->pending);
-       service->pending = NULL;
+       if (service->pending) {
+               dbus_message_unref(service->pending);
+               service->pending = NULL;
+       }
if (err < 0)
                return __connman_error_failed(msg, -err);
What is this fixing?

dbus_message_unref() handles NULL pointers relevantly, so there is no bug here.

see http://dbus.freedesktop.org/doc/api/html/dbus-message_8c_source.html#l01689

Tomasz


_______________________________________________
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Reply via email to