From: Peter Meerwald <p.meerw...@bct-electronic.com>
CC src/src_connmand-service.o
src/service.c: In function ‘__connman_service_ipconfig_indicate_state’:
src/service.c:5771:13: warning: ‘old_state’ may be used uninitialized in this
function [-Wuninitialized]
__connman_service_ipconfig_indicate_state() checks connman_ipconfig_type for
IPv4, IPv6 and
UNDEFINED -- it is better to add a default case instead of checking for value
UNDEFINED so the
compiler knows all possible valid types and can infer that old_state is always
initialized
Signed-off-by: Peter Meerwald <pme...@pmeerw.net>
---
src/service.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/service.c b/src/service.c
index e284e92..5eb9baf 100644
--- a/src/service.c
+++ b/src/service.c
@@ -5689,9 +5689,6 @@ int __connman_service_ipconfig_indicate_state(struct
connman_service *service,
return -EINVAL;
switch (type) {
- case CONNMAN_IPCONFIG_TYPE_UNKNOWN:
- return -EINVAL;
-
case CONNMAN_IPCONFIG_TYPE_IPV4:
old_state = &service->state_ipv4;
ipconfig = service->ipconfig_ipv4;
@@ -5703,6 +5700,9 @@ int __connman_service_ipconfig_indicate_state(struct
connman_service *service,
ipconfig = service->ipconfig_ipv6;
break;
+
+ default:
+ return -EINVAL;
}
if (!ipconfig)
--
1.7.9.5
_______________________________________________
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
