Hi, On 11.02.2015 13:34, Patrik Flykt wrote: >> --- a/plugins/ofono.c >> +++ b/plugins/ofono.c >> @@ -277,12 +277,11 @@ static void set_connected(struct modem_data *modem) >> if (!service) >> return; >> >> - if (method == CONNMAN_IPCONFIG_METHOD_FIXED || >> - method == CONNMAN_IPCONFIG_METHOD_DHCP) { >> - connman_service_create_ip4config(service, index); >> - >> - connman_network_set_ipv4_method(modem->network, method); >> + connman_service_create_ip4config(service, index); >> + connman_network_set_ipv4_method(modem->network, method); > So if method is off or unknown, we'd unnecessarily create and ipconfig > here, right?
connman_service_create_ip4/6config() will not create ipconfig if it already exists, and we can't set method unless we have existing ipconfig for a service. So it is necessary even when method is OFF or UNKNOWN. Br, Pasi _______________________________________________ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman