Hi Jaakko, On ke, 2015-07-15 at 15:26 +0300, Jaakko Hannikainen wrote: > Hello, > > These patches remove empty strings and leading/trailing whitespace from DBus > > input for Domains.Configuration, Proxy.Configuration, > Timeservers.Configuration > and Nameservers.Configuration. > > > > Previously, Nameservers.Configuration accepted invalid values such as > > "192.0.2.1 invalid-ip 8.8.8.8 " and then split them with space as delimiter, > > resulting in Nameservers.Configuration containing > > [192.0.2.1, , invalid-ip, 8.8.8.8, ] rather than the valid value > > [192.0.2.1, 8.8.8.8]. > > > > The v2 implements remove_empty_strings much more sensibly, fixes some style > > issues and adds a patch for Nameservers.Configuration. > > Managed to fudge the cover letter first time around, sorry.
looks good so ACK from me. Cheers, Jukka _______________________________________________ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
