Hi, these patches fix multiple issues in VPN connectivity. Thanks to Jaakko Hannikainen for finding these issues.
Patch 1 fixes a crash issue in connman-vpnd. User is able to cause segfault via connmanctl. Another serious issue is found in patch 2 where dbus library will abort if given invalid parameters. A minor memory leak is fixed by patch 3. It is only seen if one quits ConnMan while there is a DNS request pending. If there are multiple agents registered in the system, then the agent request generated by connman-vpnd might go to default agent even if the connection request came from a properly registered agent. Fixed in patch 4. VPN service was left in disconnected state if user manually disconnected it. This behaves now same way as if ConnMan was disconnecting the VPN service. The VPN service state is set to idle in patch 5. If user connects to a VPN service but cancels the connection request after agent has asked something from the user, then it is possible that subsequent connection attemps will not ask user. This is fixed in patch 6. Cheers, Jukka Jukka Rissanen (6): agent: Do not access NULL pointer in cancelling vpn: NULL dbus message in plugin input handler vpn: Clear any pending DNS resolver query when quitting vpn: Pass original sender to connman-vpnd when connecting vpn: Set disconnected VPN service to IDLE vpn: Provider state was not updated after an error include/provider.h | 3 ++- plugins/vpn.c | 37 +++++++++++++++++++++++++++++-------- src/agent.c | 9 +++++++-- src/connman.h | 3 ++- src/provider.c | 9 +++++++-- src/service.c | 3 ++- vpn/plugins/l2tp.c | 5 +++-- vpn/plugins/openconnect.c | 2 +- vpn/plugins/pptp.c | 5 +++-- vpn/plugins/vpn.c | 27 +++++++++++++++++++++++++++ vpn/vpn-provider.c | 46 ++++++++++++++++++++++++++++++++++++++++++++-- vpn/vpn-provider.h | 2 ++ 12 files changed, 129 insertions(+), 22 deletions(-) -- 2.1.0 _______________________________________________ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
