Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] Fix hang up when connecting a secure network with an empty
passphrase
(Daniel Wagner)
2. Re: [PATCH] Fix time synchronization after updating timeservers
(Daniel Wagner)
3. Re: [PATCH] vpnc: Do not lose credentials with VPN agent timeouts
(Daniel Wagner)
4. [PATCH] openvpn: Update documemtation for --proto (Daniel Wagner)
5. Re: OpenVPN key name for the protocol seems incorrect in
connman-vpn-provider.config.5.in
(Daniel Wagner)
6. Re: [PATCH] openvpn: Update documemtation for --proto
(Daniel Wagner)
7. Re: Strange connection problem (Daniel Wagner)
8. Re: connmanctl fails to connect to WiFi network having passwords ending
with a backslash character
(Daniel Wagner)
9. Re: [PATCH] wifi: Fix wireless interface not being added to tether bridge
sometimes
(Daniel Wagner)
10. RE: [PATCH] Fix time synchronization after updating
timeservers (VAUTRIN Emmanuel (Canal Plus Prestataire))
----------------------------------------------------------------------
Date: Tue, 22 Dec 2020 10:01:14 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH] Fix hang up when connecting a secure network with
an empty passphrase
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20201222090114.455kbqry3krmm...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi Emmanuel,
On Mon, Dec 21, 2020 at 06:25:06PM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> After several tests, I can not reproduce this issue on v1.38. I
> presume it has been fixed after v1.37.
Glad to hear that! Thanks for the feedback.
Thanks,
Daniel
------------------------------
Date: Tue, 22 Dec 2020 10:21:13 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH] Fix time synchronization after updating
timeservers
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20201222092113.txaxg54mbok74...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
On Thu, Dec 17, 2020 at 01:44:16PM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> When the time servers are set (timeserver_start(),
> __connman_timeserver_system_set), a call to
> __connman_timeserver_sync(NULL) is done to require a mandatory time
> synchronization.
clock.c:set_property()
__connman_timeserver_system_set()
__connman_timeserver_sync(NULL)
service = connman_service_get_default()
if (!service)
return
if (service == ts_service)
// service can't be NULL
Looking at this path, changing this to
if (default_service && service == ts_service)
is basically making it to
if (NULL)
which makes __connman_timeserver_sync() setup the time servers again
independent of the last time server. But why do you need to reset it
even when service == ts_service is true?
> Or, in this case, usually we have service == ts_service, so the
> synchronization is not done, contrary to what was expected.
What do you mean with synchronization is not done? When service is
ts_service we have a working setup.
> Adding a check to default_service, enables to know if a
> synchronisation is mandatory.
__connman_timeserver_sync() starts the time sync if we either hand in
valid default_service (!= NULL) or default_service(== NULL) and we have
a default service.
------------------------------
Date: Tue, 22 Dec 2020 10:22:38 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH] vpnc: Do not lose credentials with VPN agent
timeouts
To: Jussi Laakkonen <jussi.laakko...@jolla.com>
Cc: connman@lists.01.org
Message-ID: <20201222092238.makqohqf4re2e...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi Jussi,
On Thu, Dec 17, 2020 at 01:32:43PM +0200, Jussi Laakkonen wrote:
> Return ENOENT in case the VPN agent timeouts or there is some other
> error that does not indicate an error with login credentials. By doing
> this change the credentials are not reset with authentication error
> added to the VPN agent query. Approach here is similar to openvpn.c
> plugin.
Patch applied.
Thanks,
Daniel
------------------------------
Date: Tue, 22 Dec 2020 10:35:42 +0100
From: Daniel Wagner <w...@monom.org>
Subject: [PATCH] openvpn: Update documemtation for --proto
To: connman@lists.01.org
Cc: Daniel Wagner <w...@monom.org>
Message-ID: <20201222093542.23452-1-w...@monom.org>
The OpenVPN daemon uses --proto to set the protocol version to
use. ConnMan's documentation says OpenVPN.Protocol to use but the
implementation allows only OpenVPN.Proto. Update the documentation
accordingly.
---
doc/connman-vpn-provider.config.5.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/connman-vpn-provider.config.5.in
b/doc/connman-vpn-provider.config.5.in
index cea99e65dcf3..036b60c1ed0f 100644
--- a/doc/connman-vpn-provider.config.5.in
+++ b/doc/connman-vpn-provider.config.5.in
@@ -105,7 +105,7 @@ MTU of the tunnel.
.B OpenVPN.NSCertType=client \fR|\fB server
Peer certificate type, either \fBclient\fP or \fBserver\fP.
.TP
-.BI OpenVPN.Protocol= protocol
+.BI OpenVPN.Proto= protocol
Use \fIprotocol\fP.
.TP
.BI OpenVPN.Port= port
--
2.29.2
------------------------------
Date: Tue, 22 Dec 2020 10:36:18 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: OpenVPN key name for the protocol seems incorrect in
connman-vpn-provider.config.5.in
To: dinoallosaurus1...@gmail.com
Cc: connman@lists.01.org
Message-ID: <20201222093618.p4lerkwlnhyoo...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi,
On Mon, Dec 21, 2020 at 01:55:06PM -0000, dinoallosaurus1...@gmail.com wrote:
> Hello everyone,
> A few days ago I decided to set up my OpenVPN connection with
> connman-vpn, I followed the documentation and configured the protocol
> used for the connection with:
Thanks for the report. I'll update the documentation accordingly.
Daniel
------------------------------
Date: Tue, 22 Dec 2020 10:36:40 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH] openvpn: Update documemtation for --proto
To: connman@lists.01.org
Message-ID: <20201222093640.and4dwqivyc57...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
On Tue, Dec 22, 2020 at 10:35:42AM +0100, Daniel Wagner wrote:
> The OpenVPN daemon uses --proto to set the protocol version to
> use. ConnMan's documentation says OpenVPN.Protocol to use but the
> implementation allows only OpenVPN.Proto. Update the documentation
> accordingly.
Patch applied.
------------------------------
Date: Tue, 22 Dec 2020 10:37:20 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: Strange connection problem
To: Thomas Green <tgre...@sorenson.com>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20201222093720.5himqtodmwpr6...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
On Mon, Dec 21, 2020 at 08:06:42PM +0000, Thomas Green wrote:
> Has anyone been able to look at this or my logfile? I'm still in the dark as
> to what is going on.
Sorry, I haven't found time to look at it.
------------------------------
Date: Tue, 22 Dec 2020 11:19:05 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: connmanctl fails to connect to WiFi network having
passwords ending with a backslash character
To: * * <des...@gmail.com>
Cc: connman@lists.01.org
Message-ID: <20201222101905.v6u5aus4zathx...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi,
On Tue, Dec 22, 2020 at 12:00:03AM -0000, * * wrote:
> I ran into the following issue with connman recently. I would have
> prefered to open a Jira ticket for that but I don't seem to be able to
> request access to https://01.org/jira/projects/CM which is rather
> expected though. I hope this is the right place to post this in this
> context, please someone tell me otherwise.
I've just cleanup all stale issues in the Jira. The idea was that we can
use it for new bugs reports. It's useless if we as community can't login
in. Furthermore, the configuration of this Jira is also targeted to
Intel's product development and has lot's of bells and whistles upstream
never will use.
Thus I was pondering to use something else. Obvious choice are a
gitlab/github but we don't need the rest they offer, especially the
workflow with PR, as the development happens here on the mailing list.
So I am not sure what to do here.
> # cat settings
> Passphrase="kjHTJ235nnM!0\
>
> # connmanctl connect wifi_[...]
> Error /net/connman/service/wifi_[...]: Input/output error
>
> # cat settings
> Passphrase="kjHTJ235nnM!0
We use GLib's key file API to read and write the settings file. The
problem might be we that we don't escape the special chars when writing
the passhphrase and later we retrieve it using a plain
g_key_file_get_string(). The documenation says
'... this function handles escape sequences like \s.'
So clearly we need to encode the string when saving it to settings.
> Also note that most modern WiFi tools (e.g. wpa_supplicant) offer the
> possibility to store hashed passphrases rather than clear ones in
> their config files, for 2 good reasons:
> 1. It is safer and good practice to store a hashed password rather than a
> clear one;
> 2. a hash will never have any special character issue such as the one
> described in this ticket.
There was a lot discussion about this in the past. I can't remember why
we have decided to keep them in plain text though. Just note, to declare
'it's safer' without a context doesn't say anything. What's the attack
vector, what is the asset, what does the attacker gain with it, ..w. are
the question to answer first.
> As a side note, my WiFi password do start with a double quote
> character as well as ending witht a backslash. I was not specifically
> looking for trouble but it seems I have been very "unlucky" with the
> password generator I used at the time I setup the network.
See it positive, you are good tester. You find the bugs!
> I have since plugged my rPi to my network via ethernet rather than
> WiFi for bandwidth reasons so it is not a blocker to me anymore, but I
> believe I may not be the only one hitting this wall so it may worth a
> look into.
Thanks for the report I'll think I know exactly where the problem is.
Daniel
------------------------------
Date: Tue, 22 Dec 2020 11:23:01 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH] wifi: Fix wireless interface not being added to
tether bridge sometimes
To: Jonathan Liu <net...@gmail.com>
Cc: connman@lists.01.org
Message-ID: <20201222102301.ivd5umnqs7enm...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi Jonathan,
On Tue, Dec 22, 2020 at 01:55:42PM +1100, Jonathan Liu wrote:
> For Broadcom BCM4356 chipset with brcmfmac driver, the IFF_LOWER_UP flag
> did not always change state in wifi_newlink() but remained set when
> changing from STA mode to AP mode. This resulted in handle_tethering()
> not being called to add the wireless interface to the tether bridge.
>
> To resolve the issue, always call handle_tethering() as long as the
> IFF_LOWER_UP flag is set instead of only when IFF_LOWER_UP changes
> from unset to set. The handle_tethering() function already has checks
> in place to avoid adding the wireless interface to the tether bridge
> more than once.
Thanks for the excellent commit message. Patch applied.
Daniel
------------------------------
Date: Tue, 22 Dec 2020 09:55:26 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] Fix time synchronization after updating
timeservers
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb47944b97998b5c487b03ef6d93...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: multipart/alternative; boundary="_000_PR1PR02MB47944B
97998B5C487B03EF6D93DF0PR1PR02MB4794eurp_"
--_000_PR1PR02MB47944B97998B5C487B03EF6D93DF0PR1PR02MB4794eurp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Hi Daniel,
Maybe it will be easier if I describe a test case.
When starting my board with TimeUpdates in auto and Timeservers to an empty=
array, the Time is set to /etc/timestamp default value.
After a while (I am online, with internet working, ntp reachable...), when =
I decide to get the time from the network, by setting Timeservers to real N=
TP configurations, the Time is not updated to the current date and time as =
expected, but continue incrementing from its default value (/etc/timestamp)=
.
B.R.
Emmanuel
--_000_PR1PR02MB47944B97998B5C487B03EF6D93DF0PR1PR02MB4794eurp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Hi Daniel,</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Maybe it will be easier if I describe a test case.</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
When starting my board with TimeUpdates in auto and Timeservers to an empty=
array, the Time is set to /etc/timestamp default value.</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
After a while (I am online, with internet working, ntp reachable...), when =
I decide to get the time from the network, by setting Timeservers to real N=
TP configurations, the Time is not updated to the current date and time as =
expected, but continue incrementing
from its default value (/etc/timestamp).</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
B.R.</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Emmanuel<br>
</div>
</body>
</html>
--_000_PR1PR02MB47944B97998B5C487B03EF6D93DF0PR1PR02MB4794eurp_--
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 62, Issue 26
***************************************
